[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 05/12] VMstate test: basic VMState testin
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 05/12] VMstate test: basic VMState testing mechanism |
Date: |
Mon, 28 Jul 2014 15:52:00 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote:
> In this patch, I have made the following changes:
>
> * changed the DPRINT statement.
> * renamed the variables.
> * added noqdev variable which decides which option to use for resetting.
> * added devices option which can help in resetting one or many devices
> (only qdevified ones).
> * updated the documentation.
>
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
> qapi-schema.json | 26 ++++++
> qmp-commands.hx | 37 ++++++++
> savevm.c | 251
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 314 insertions(+)
>
> +#
> +# @noqdev: boolean variable which decides whether to use qdevified devices
> +# or not. Will be removed when all the devices have been qdevified.
Please name this 'x-noqdev' if it is likely to be removed in the future,
to make it obvious that it is not part of the permanent API. Also, mark
it as optional, with a sane default, so that you can test the API
without being forced to supply this temporary parameter.
> +#
> +# @devices: (optional) helps in resetting particular qdevified decices
> +# that have been registered with SaveStateEntry
> +#
> +# Since 2.2
> +##
> +{ 'command': 'test-vmstates',
> + 'data': {'*iterations': 'int',
> + '*period': 'int',
> + 'noqdev': 'bool',
> + '*qdevices': 'VMStatesQdevDevices' } }
Based on my comments on 3/12, if you rename that qapi to:
{ 'type': 'VMStatesQdevDevice',
'data': { 'device': 'str' } }
then this should be
'*qdevices': [ 'VMStatesQdevDevice' ]
> +
> +- "devices": (optional) helps in resetting particular qdevified decices
s/decices/devices/
> + that have been registered with SaveStateEntry
> +
> +
> +Example:
> +
> +-> { "execute": "test-vmstates",
> + "arguments": {
> + "iterations": 10,
> + "period": 100,
> + "noqdev": false } }
If noqdev is going to disappear, I wouldn't include it in the example.
Conversely, showing how to use 'devices' might be useful.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH RFC v2 01/12] QEMUSizedBuffer/QEMUFile, (continued)
- [Qemu-devel] [PATCH RFC v2 02/12] reset handler for qdevified devices, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 03/12] VMState test: query command to extract the qdevified device names, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 04/12] VMState test: hmp interface for showing qdevified devices, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 05/12] VMstate test: basic VMState testing mechanism, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 06/12] VMState test: hmp interface for vmstate testing, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 07/12] VMState test: qmp interface for querying the vmstate testing process, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 08/12] VMState test: hmp interface for querying the vmstate testing process, Sanidhya Kashyap, 2014/07/25
- [Qemu-devel] [PATCH RFC v2 09/12] VMState test: update period of vmstate testing process, Sanidhya Kashyap, 2014/07/25