[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC v2 11/12] VMState test: cancel mechanism for
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH RFC v2 11/12] VMState test: cancel mechanism for an already running vmstate testing process |
Date: |
Tue, 29 Jul 2014 10:50:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/25/2014 09:39 AM, Sanidhya Kashyap wrote:
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
> qapi-schema.json | 9 +++++++++
> qmp-commands.hx | 19 +++++++++++++++++++
> savevm.c | 16 ++++++++++++++--
> 3 files changed, 42 insertions(+), 2 deletions(-)
>
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 13e922e..91f1672 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -3574,3 +3574,12 @@
> ##
> { 'command' : 'test-vmstates-set-period',
> 'data' : { 'period': 'int' } }
> +
> +##
> +# @log-dirty-bitmap-cancel
> +#
> +# cancel the testing vmstates process
> +#
> +# Since 2.2
> +##
> +{ 'command': 'test-vmstates-cancel' }
Command name doesn't match documentation.
> +
> +SQMP
> +test-vmstates-cancel
> +--------------
Make the ---- line up to the command name.
> +++ b/savevm.c
> @@ -1365,8 +1365,12 @@ static void vmstate_test_cb(void *opaque)
> if (saved_vm_running) {
> vm_start();
> }
> - timer_mod(v->timer, qemu_clock_get_ms(QEMU_CLOCK_REALTIME) +
> - v->period);
> + if (v->active_state) {
Indentation is off.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature