[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8] block: Add status callback to bdrv_amend_op
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/8] block: Add status callback to bdrv_amend_options() |
Date: |
Wed, 30 Jul 2014 08:50:51 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 07/25/2014 12:07 PM, Max Reitz wrote:
> Depending on the changed options and the image format,
> bdrv_amend_options() may take a significant amount of time. In these
> cases, a way to be informed about the operation's status is desirable.
>
> Since the operation is rather complex and may fundamentally change the
> image, implementing it as AIO or a couroutine does not seem feasible. On
> the other hand, implementing it as a block job would be significantly
> more difficult than a simple callback and would not add benefits other
> than progress report to the amending operation, because it should not
> actually be run as a block job at all.
>
> A callback may not be very pretty, but it's very easy to implement and
> perfectly fits its purpose here.
Agree with this reasoning.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 5 +++--
> block/qcow2.c | 5 ++++-
> include/block/block.h | 5 ++++-
> include/block/block_int.h | 3 ++-
> qemu-img.c | 2 +-
> 5 files changed, 14 insertions(+), 6 deletions(-)
Good for 2.2, and looks like this patch is the same in both your
original and alternate series.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 2/8] qemu-img: Add progress output for amend, (continued)
- [Qemu-devel] [PATCH 3/8] qemu-img: Fix insignifcant memleak, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 4/8] block/qcow2: Make get_refcount() global, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 5/8] block/qcow2: Implement status CB for amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 6/8] block/qcow2: Simplify shared L2 handling in amend, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 7/8] block/qcow2: Speed up zero cluster expansion, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 8/8] iotests: Expand test 061, Max Reitz, 2014/07/25
- [Qemu-devel] [PATCH 1/8] block: Add status callback to bdrv_amend_options(), Max Reitz, 2014/07/25
- Re: [Qemu-devel] [PATCH 1/8] block: Add status callback to bdrv_amend_options(),
Eric Blake <=