Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

[Stefan Berger]

"Michael S. Tsirkin" <address@hidden>
wrote on 07/30/2014 11:25:25 AM:

> From: "Michael S. Tsirkin" <address@hidden>
> To: Stefan Berger/Watson/address@hidden
> Cc: address@hidden, address@hidden,
Stefan Berger 
> <address@hidden>
> Date: 07/30/2014 11:25 AM
> Subject: Re: [PATCH v2] Add ACPI tables for TPM
> 
> On Wed, Jul 30, 2014 at 11:13:07AM -0400, Stefan Berger wrote:
> > "Michael S. Tsirkin" <address@hidden> wrote on
07/30/2014 11:07:28 AM:
> > 
> > 
> > > > >If you need bios to allocate this memory, then
we will
> > > > >need a new allocation type for this, add it to
linker
> > > > >in bios and qemu.
> > > >
> > > > Why does the BIOS 'need' to allocate it? Why can it
not just 
> use the memory
> > > > that QEMU allocates? Obviously I am using the 'pointer
> relocation' feature
> > > > of the BIOS to bend the pointer in the TCPA table to
this log area.
> > >
> > > You tell me - your patches make BIOS allocate it.
> > 
> > No, the BIOS does not allocate it, it merely relocates the pointer.
> 
> Yes it does :)

Of course it allocates memory for the ACPI tables,
but it doesn't do this by an instruction 'allocate memory and put the pointer
here.'

> You pushed the log as part of the table_data which bios
> allocates memory for, and reads from QEMU.

Yes, and then it relocates that pointer to the beginning
of the log area. That log area is part of that allocation.

Following what I stated in the other mail regarding
the S3 resume vector and the slew of ACPI tables that need to be kept around,
why do we need to treat the TCPA table differently
?

   Stefan