Re: [Qemu-devel] [PATCH v2] Add ACPI tables for TPM

[Laszlo Ersek]

On 07/30/14 18:10, Michael S. Tsirkin wrote:
> On Wed, Jul 30, 2014 at 12:03:46PM -0400, Stefan Berger wrote:
>> Laszlo Ersek <address@hidden> wrote on 07/30/2014 11:58:52 AM:

>>> In the short term, probably skip TCPA, or advise users in documentation
>>> not to enable the TPM device when running OVMF.
> 
> Hmm but doesn't OVMF rely on all tables being packed without holes
> in memory?
> I remember it did, and if it still does, this breaks unless TCPA is
> the last ...

Ah, do you mean that the table size field in the ACPI table header of
TCPA would *not* include the TCG event log that is tacked-on? Yes, that
would certainly trip up the parser. It advances by looking at the table
size fields in the headers.

>> I guess we can do that. You can skip the TCPA for now; once the UEFI has TPM
>> support, this table would then  be needed.

> If it doesn't work anyway, we can just tell people not to enable TPM
> with OVMF. No need for hack in OVMF to skip it.

Agree 100%.

Thanks
Laszlo