[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions |
Date: |
Thu, 31 Jul 2014 20:51:26 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 07/31/2014 08:32 PM, address@hidden wrote:
> From: Gonglei <address@hidden>
>
> $WHATEVER: don't use 'Yoda conditions'
>
> 'Yoda conditions' are not part of idiomatic QEMU coding
> style, so rewrite them in the more usual order.
>
> v2:
> - add more specific commit messages suggested by PMM, thanks.
> - introduce section of conditional statement to CODING_STYLE.
>
>
> Gonglei (8):
> CODING_STYLE: Section about conditional statement
> usb: a trivial code change for more idiomatic writing style
You didn't rename the subject lines. I think the request you were given
on v1 was to name this patch:
usb: don't use 'Yoda conditions'
> audio: a trivial code change for more idiomatic writing style
audio: don't use 'Yoda conditions'
> isa-bus: a trivial code change for more idiomatic writing style
> a trivial code change for more idiomatic writing style
> spice: a trivial code change for more idiomatic writing style
> vl: a trivial code change for more idiomatic writing style
> vmxnet3: a trivial code change for more idiomatic writing style
and so on
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 3/8] audio: a trivial code change for more idiomatic writing style, (continued)
- [Qemu-devel] [PATCH v2 3/8] audio: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH v2 2/8] usb: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH v2 1/8] CODING_STYLE: Section about conditional statement, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH v2 6/8] spice: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH v2 7/8] vl: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH v2 5/8] a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- [Qemu-devel] [PATCH v2 4/8] isa-bus: a trivial code change for more idiomatic writing style, arei.gonglei, 2014/07/31
- Re: [Qemu-devel] [PATCH v2 for-2.2 0/8] about Yoda conditions,
Eric Blake <=