[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user/syscall.c : Minor cleanups of timer_
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] linux-user/syscall.c : Minor cleanups of timer_create handling. |
Date: |
Sat, 2 Aug 2014 23:50:37 +0100 |
On 2 August 2014 23:48, Erik de Castro Lopo <address@hidden> wrote:
> Peter Maydell wrote:
>
>> Doesn't this turn a timer_create(clkid, NULL, phtimer) into a
>> timer_create(clkid, something-not-NULL, phtimer) ? That
>> doesn't seem right to me (and the code you've deleted here
>> is the common idiom in syscall.c for handling those "arg
>> is pointer-to-struct-or-NULL" cases).
>
> You're right. Thanks. I will amend this.
Amend it to what? The current code looks fine to me,
so I'm not sure what bug you're trying to fix here.
thanks
-- PMM
[Qemu-devel] [PATCH] linux-user: Add missing unlock_user_struct to timer_create., Erik de Castro Lopo, 2014/08/02