[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 07/30] ide: simplify async_cmd_done callbacks
From: |
John Snow |
Subject: |
[Qemu-devel] [PATCH v2 07/30] ide: simplify async_cmd_done callbacks |
Date: |
Mon, 4 Aug 2014 17:11:08 -0400 |
From: Paolo Bonzini <address@hidden>
Drop the unused return value.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: John Snow <address@hidden>
---
hw/ide/ahci.c | 4 +---
hw/ide/internal.h | 2 +-
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
index 679357f..e494503 100644
--- a/hw/ide/ahci.c
+++ b/hw/ide/ahci.c
@@ -1116,7 +1116,7 @@ static int ahci_dma_add_status(IDEDMA *dma, int status)
return 0;
}
-static int ahci_async_cmd_done(IDEDMA *dma)
+static void ahci_async_cmd_done(IDEDMA *dma)
{
AHCIDevice *ad = DO_UPCAST(AHCIDevice, dma, dma);
@@ -1130,8 +1130,6 @@ static int ahci_async_cmd_done(IDEDMA *dma)
ad->check_bh = qemu_bh_new(ahci_check_cmd_bh, ad);
qemu_bh_schedule(ad->check_bh);
}
-
- return 0;
}
static void ahci_irq_set(void *opaque, int n, int level)
diff --git a/hw/ide/internal.h b/hw/ide/internal.h
index 34064cf..940dd45 100644
--- a/hw/ide/internal.h
+++ b/hw/ide/internal.h
@@ -434,7 +434,7 @@ struct IDEDMAOps {
DMAIntFunc *set_unit;
DMAIntFunc *add_status;
DMAVoidFunc *set_inactive;
- DMAFunc *async_cmd_done;
+ DMAVoidFunc *async_cmd_done;
DMARestartFunc *restart_cb;
DMAVoidFunc *reset;
};
--
1.9.3
- [Qemu-devel] [PATCH v2 00/30] AHCI test suite framework, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 01/30] blkdebug: report errors on flush too, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 05/30] ide: simplify reset callbacks, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 02/30] libqtest: add QTEST_LOG for debugging qtest testcases, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 07/30] ide: simplify async_cmd_done callbacks,
John Snow <=
- [Qemu-devel] [PATCH v2 03/30] ide-test: add test for werror=stop, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 09/30] ide: wrap start_dma callback, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 08/30] ide: simplify start_transfer callbacks, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 06/30] ide: simplify set_inactive callbacks, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 11/30] ide: fold add_status callback into set_inactive, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 04/30] ide: stash aiocb for flushes, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 10/30] ide: remove wrong setting of BM_STATUS_INT, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 13/30] ide: move retry constants out of BM_STATUS_* namespace, John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 12/30] ide: move BM_STATUS bits to pci.[ch], John Snow, 2014/08/04
- [Qemu-devel] [PATCH v2 18/30] q35: Enable the ioapic device to be seen by qtest., John Snow, 2014/08/04