[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 02/10] monitor: fix access freed memory
From: |
zhanghailiang |
Subject: |
[Qemu-devel] [PATCH v5 02/10] monitor: fix access freed memory |
Date: |
Mon, 11 Aug 2014 16:53:01 +0800 |
The function monitor_fdset_dup_fd_find_remove() references member of 'mon_fdset'
which may be freed in function monitor_fdset_cleanup()
Reviewed-by: Gonglei <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
---
monitor.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/monitor.c b/monitor.c
index 5bc70a6..41e46a6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2532,8 +2532,10 @@ static int monitor_fdset_dup_fd_find_remove(int dup_fd,
bool remove)
{
MonFdset *mon_fdset;
MonFdsetFd *mon_fdset_fd_dup;
+ int64_t id = -1;
QLIST_FOREACH(mon_fdset, &mon_fdsets, next) {
+ id = mon_fdset->id;
QLIST_FOREACH(mon_fdset_fd_dup, &mon_fdset->dup_fds, next) {
if (mon_fdset_fd_dup->fd == dup_fd) {
if (remove) {
@@ -2542,7 +2544,7 @@ static int monitor_fdset_dup_fd_find_remove(int dup_fd,
bool remove)
monitor_fdset_cleanup(mon_fdset);
}
}
- return mon_fdset->id;
+ return id;
}
}
}
--
1.7.12.4
- [Qemu-devel] [PATCH v5 00/10] fix three bugs about use-after-free and several api abuse, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 04/10] ivshmem: check the value returned by fstat(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 03/10] virtio-blk: fix reference a pointer which might be freed, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 06/10] slirp/misc: Use g_malloc() instead of malloc(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 05/10] util/path: Use the GLib memory allocation routines, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 08/10] tests/bios-tables-test: check the value returned by fopen(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 02/10] monitor: fix access freed memory,
zhanghailiang <=
- [Qemu-devel] [PATCH v5 01/10] l2cap: fix access freed memory, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 10/10] block/vvfat: fix setbuf stream parameter may be NULL, zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 09/10] tcg: check return value of fopen(), zhanghailiang, 2014/08/11
- [Qemu-devel] [PATCH v5 07/10] linux-user: check return value of malloc(), zhanghailiang, 2014/08/11