Re: [Qemu-devel] [PATCH v3 0/9] qemu-log dfilter and perf.map changes

[Alex Bennée]

Alex Bennée writes:

> Hi,
>
> I've been doing a fair amount of performance analysis recently so I
> thought it would be worth polishing up these patches from the last
> review. I've merged the perf.map patch which was posted separately as
> it makes sense with this series. I've also included some tweaks Peter
> made previously which go with this set. I have also done some light
> re-factoring of the tcg call to make it easier to pull the size of the
> translated code out for a given Translation Block which is useful for
> the later patches.
>
> I think this is ready for merging if no one objects.

Ping!

I would be grateful if some review eyes could be cast over this? It
seems I'm pretty good at picking files that aren't actively covered by
maintainers though so I've widened the CC list to people who have also
hacked in the various areas.

Regards,

> Changes:
>   - dropped the disable chain flag
>   - move perf.map stuff up into translate-all.c
>   - include prolog/epilog in the perf.map dump
>   - include tc_size in TranslationBlock
>   - cleaned up documentation of the -dfilter params
>   - used GArray instead of GList for debug_regions
>
> Alex Bennée (7):
>   tcg: add ability to dump /tmp/perf-<pid>.map files
>   tcg: light re-factor and pass down TranslationBlock
>   qemu-log: correct help text for -d cpu
>   qemu-log: support simple pid substitution in logfile
>   qemu-log: new option -dfilter to limit output
>   qemu-log: dfilter-ise exec, out_asm, and op_opt
>   target-arm: dfilter support for in_asm, op, opt_op
>
> Peter Maydell (2):
>   qemu-log: Avoid function call for disabled qemu_log_mask logging
>   qemu-log: Improve the "exec" TB execution logging
>
>  cpu-exec.c                 | 21 ++++++-----
>  include/exec/exec-all.h    |  9 +++--
>  include/qemu-common.h      |  2 ++
>  include/qemu/log.h         | 28 +++++++++++++--
>  qemu-log.c                 | 87 
> ++++++++++++++++++++++++++++++++++++++--------
>  qemu-options.hx            | 26 ++++++++++++++
>  target-arm/translate-a64.c |  6 ++--
>  target-arm/translate.c     |  6 ++--
>  tcg/tcg.c                  | 33 +++++++++---------
>  tcg/tcg.h                  |  5 ++-
>  translate-all.c            | 70 ++++++++++++++++++++++++-------------
>  vl.c                       |  7 ++++
>  12 files changed, 225 insertions(+), 75 deletions(-)

-- 
Alex Bennée