[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 03/10] spapr_pci: Make find_phb()/find_dev()
|
From: |
Alexey Kardashevskiy |
|
Subject: |
Re: [Qemu-devel] [RFC PATCH 03/10] spapr_pci: Make find_phb()/find_dev() public |
|
Date: |
Tue, 12 Aug 2014 00:56:07 +1000 |
|
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
On 08/11/2014 09:39 PM, Alexander Graf wrote:
>
> On 31.07.14 11:34, Alexey Kardashevskiy wrote:
>> This makes find_phb()/find_dev() public and changed its names
>> to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to
>> be used from other parts of QEMU such as VFIO DDW (dynamic DMA window)
>> or VFIO PCI error injection or VFIO EEH handling - in all these
>> cases there are RTAS calls which are addressed to BUID+config_addr
>> in IEEE1275 format.
>>
>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>
> Is there any particular reason these RTAS calls can't get handled inside of
> spapr_pci.c? After all, if they work on PCI granularity, they are
> semantically bound to the PCI PHB emulation.
Creation - yes, addressed to PHB BUID. Deletion - no, addressed to LIOBN
which has nothing to do with PCI.
--
Alexey