[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v3 4/6] VMState test: querying the vmstate t
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH v3 4/6] VMState test: querying the vmstate testing process |
Date: |
Mon, 11 Aug 2014 10:35:21 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/09/2014 12:26 AM, Sanidhya Kashyap wrote:
> This patch has been updated to provide the following information:
> * Added a new return value in the form of devices' info that provides
> the device name as well as the version number.
> * provides the hmp interface - info test_vmstates and qmp interface -
> query-test-vmstates to obtain the information about the running
> vmstate testing process.
Patch changelog information belongs...
>
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
...after the --- separator.
> hmp-commands.hx | 4 +++-
> hmp.c | 31 +++++++++++++++++++++++++++++++
> hmp.h | 1 +
> monitor.c | 7 +++++++
> qapi-schema.json | 37 +++++++++++++++++++++++++++++++++++++
> qmp-commands.hx | 28 ++++++++++++++++++++++++++++
> savevm.c | 29 +++++++++++++++++++++++++++++
> 7 files changed, 136 insertions(+), 1 deletion(-)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> @@ -1799,13 +1801,13 @@ ETEXI
> "period: (optional) sleep interval in milliseconds
> between each iteration",
> .mhandler.cmd = hmp_test_vmstates,
> },
> +
> STEXI
> @item test_vmstates
> @findex test_vmstates
> dumps and reads the device state's data from the memory for testing purpose
> ETEXI
>
> -
> STEXI
Spurious whitespace changes?
> +++ b/qapi-schema.json
> @@ -3528,3 +3528,40 @@
> 'data': {'*iterations': 'int',
> '*period': 'int',
> '*devices': [ 'QemuDevice' ] } }
> +
> +##
> +# @VMStateLogStateInfo
Having State in the name twice sounds redundant. Would 'VMStateLogInfo'
be sufficient?
> +{ 'type': 'VMStateLogStateInfo',
> + 'data': { 'current-iteration': 'int',
> + 'iterations': 'int',
> + 'period': 'int',
> + 'devices': [ 'QemuDevice' ] } }
> +
> +##
> +# @query-test-vmstates
> +#
> +# Get the current parameters value of the vmstate testing process.
> +#
> +# Returns VMStateLogStateInfo structure.
> +#
> +# Since 2.2
> +##
> +{ 'command': 'query-test-vmstates', 'returns': 'VMStateLogStateInfo' }
> +Example:
> +
> +-> { "execute": "query-test-vmstates" }
> +<- { "return": {
> + "current_iteration": 3,
Doesn't match the spelling documented in the .json.
> + "iterations": 100,
> + "period": 100,
> + "devices": [ { 'device': 'hpet', 'version': 2 },
QMP uses ", not '. Please paste an actual example (possibly trimmed, if
the list of devices is otherwise too huge) rather than trying to write
it by hand.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [RFC PATCH v3 0/6] VMState testing, Sanidhya Kashyap, 2014/08/09
- [Qemu-devel] [RFC PATCH v3 1/6] QEMUSizedBuffer/QEMUFile, Sanidhya Kashyap, 2014/08/09
- [Qemu-devel] [RFC PATCH v3 2/6] VMState test: get information about the registered devices, Sanidhya Kashyap, 2014/08/09
- [Qemu-devel] [RFC PATCH v3 5/6] VMState test: update period of vmstate testing process, Sanidhya Kashyap, 2014/08/09
- [Qemu-devel] [RFC PATCH v3 4/6] VMState test: querying the vmstate testing process, Sanidhya Kashyap, 2014/08/09
- Re: [Qemu-devel] [RFC PATCH v3 4/6] VMState test: querying the vmstate testing process,
Eric Blake <=
- [Qemu-devel] [RFC PATCH v3 3/6] VMstate test: basic VMState testing mechanism, Sanidhya Kashyap, 2014/08/09
- [Qemu-devel] [RFC PATCH v3 6/6] VMState test: cancel mechanism for an already running vmstate testing process, Sanidhya Kashyap, 2014/08/09