[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 21/24] linux-user: clock_nanosleep errno Handling on
From: |
riku . voipio |
Subject: |
[Qemu-devel] [PULL 21/24] linux-user: clock_nanosleep errno Handling on PPC |
Date: |
Fri, 15 Aug 2014 14:01:39 +0300 |
From: Tom Musta <address@hidden>
The clock_nanosleep syscall is unusual in that it returns positive
numbers in error handling situations, versus returning -1 and setting
errno, or returning a negative errno value. On POWER, the kernel will
set the SO bit of CR0 to indicate failure in a syscall. QEMU has
generic handling to do this for syscalls with standard return values.
Add special case code for clock_nanosleep to handle CR0 properly.
Signed-off-by: Tom Musta <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>
---
linux-user/syscall.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index a24356d..e4be32c 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -9103,6 +9103,14 @@ abi_long do_syscall(void *cpu_env, int num, abi_long
arg1,
ret = get_errno(clock_nanosleep(arg1, arg2, &ts, arg4 ? &ts : NULL));
if (arg4)
host_to_target_timespec(arg4, &ts);
+
+#if defined(TARGET_PPC)
+ /* clock_nanosleep is odd in that it returns positive errno values.
+ * On PPC, CR0 bit 3 should be set in such a situation. */
+ if (ret) {
+ ((CPUPPCState *)cpu_env)->crf[0] |= 1;
+ }
+#endif
break;
}
#endif
--
2.0.1
- [Qemu-devel] [PULL 12/24] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call, (continued)
- [Qemu-devel] [PULL 12/24] linux-user: Dereference Pointer Argument to ipc/semctl Sys Call, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 15/24] linux-user: Conditionally Pass Attribute Pointer to mq_open(), riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 24/24] linux-user: check return value of malloc(), riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 23/24] linux-user: writev Partial Writes, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 18/24] linux-user: Detect fault in sched_rr_get_interval, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 04/24] linux-user: Fix syscall instruction usermode emulation on X86_64, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 01/24] linux-user: /proc/self/maps content, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 22/24] linux-user: Support target-to-host translation of mlockall argument, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 19/24] linux-user: Move get_ppc64_abi, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 20/24] linux-user: Minimum Sig Handler Stack Size for PPC64 ELF V2, riku . voipio, 2014/08/15
- [Qemu-devel] [PULL 21/24] linux-user: clock_nanosleep errno Handling on PPC,
riku . voipio <=
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Peter Maydell, 2014/08/15
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Riku Voipio, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Joakim Tjernlund, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Peter Maydell, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Joakim Tjernlund, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Peter Maydell, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Joakim Tjernlund, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Peter Maydell, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Joakim Tjernlund, 2014/08/18
- Re: [Qemu-devel] [PULL 00/24] Linux-user updates, Riku Voipio, 2014/08/18