[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as th

From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL 19/20] memory: Use canonical path component as the name
Date: Wed, 20 Aug 2014 08:50:31 +0100

On 20 August 2014 06:04, Peter Crosthwaite <address@hidden> wrote:
> On Wed, Aug 20, 2014 at 5:01 AM, Peter Maydell <address@hidden> wrote:
>> I think we need to revert this (commit b0225c2c0d8) until
>> both the Xen callsites are fixed and the leak issue is
>> dealt with.
> Have half a plan on the leak issue. With
> object_get_canonical_path_component() being used increasing as a "get
> me the already set, name of this object", I think it's better to just
> change to API to return const and remove the free burden from all call
> sites completely. If call sites really want a fresh copy they can take
> one themselves. Patch on list imminently.

I'm going to go ahead and revert this patch for the moment so
we can take our time reviewing that patch set.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]