[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors,
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted |
Date: |
Thu, 21 Aug 2014 06:33:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.7.0 |
On 08/21/2014 06:22 AM, Markus Armbruster wrote:
> Kevin Wolf <address@hidden> writes:
>
>> The worst part is that it got a Reviewed-by which might just have fooled
>> me if Fam hadn't reviewed it as well. :-/
>
> This kind of idiotic error is hard to spot in review for the same reason
> it's easy to make when tired.
Indeed; I had merely reviewed that the patch looked sane, and not
actually tested against a testsuite, so I'm glad Fam caught it. There's
a reason I've been sticking with Reviewed-by and not Tested-by, although
I agree that enhancing the testsuite to make sure dumb things like this
get caught is worthwhile.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Markus Armbruster, 2014/08/20
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Eric Blake, 2014/08/20
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Fam Zheng, 2014/08/20
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Markus Armbruster, 2014/08/21
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Fam Zheng, 2014/08/21
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Kevin Wolf, 2014/08/21
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted, Markus Armbruster, 2014/08/21
- Re: [Qemu-devel] [PATCH 1/1] vmdk: Use bdrv_nb_sectors() where sectors, not bytes are wanted,
Eric Blake <=