Re: [Qemu-devel] [PATCH 2/3] hw/core/loader: implement load_uimage_at

[Alexander Graf]

> Am 21.08.2014 um 22:56 schrieb Max Filippov <address@hidden>:
> 
> Hi Alex,
> 
>> On Thu, Aug 21, 2014 at 1:16 PM, Alexander Graf <address@hidden> wrote:
>>> On 12.08.14 06:22, Max Filippov wrote:
>>> load_uimage_at loads kernel image at the specified address instead of
>>> the address recorded in the uImage header.
>>> 
>>> Cc: address@hidden
>>> Signed-off-by: Max Filippov <address@hidden>
>> 
>> Please check out load_elf() and friends. The way we usually handle these
>> things is by providing a special translate_fn function callback that
>> adds the offset.
> 
> Thanks for your comment. Nobody seems to need this functionality except
> xtensa, so I tried to solve it the least intrusive way. But sure, I can add
> generic translation support to uimage loader.

I think I personally would prefer to have the interfaces be as consistent as 
possible, yeah :).

Alex

> 
> -- 
> Thanks.
> -- Max