[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions wi
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows |
Date: |
Mon, 25 Aug 2014 00:18:16 +0200 |
From: Paolo Bonzini <address@hidden>
The regions are destroyed and recreated on configuration space accesses.
We need to destroy them before the containing PCIBridgeWindows object
is freed.
Reported-by: Gonglei <address@hidden>
Reported-by: Knut Omang <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
hw/pci/pci_bridge.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c
index 1307265..40c97b1 100644
--- a/hw/pci/pci_bridge.c
+++ b/hw/pci/pci_bridge.c
@@ -219,6 +219,12 @@ static void pci_bridge_region_del(PCIBridge *br,
PCIBridgeWindows *w)
static void pci_bridge_region_cleanup(PCIBridge *br, PCIBridgeWindows *w)
{
+ object_unparent(OBJECT(&w->alias_io));
+ object_unparent(OBJECT(&w->alias_mem));
+ object_unparent(OBJECT(&w->alias_pref_mem));
+ object_unparent(OBJECT(&w->alias_vga[QEMU_PCI_VGA_IO_LO]));
+ object_unparent(OBJECT(&w->alias_vga[QEMU_PCI_VGA_IO_HI]));
+ object_unparent(OBJECT(&w->alias_vga[QEMU_PCI_VGA_MEM]));
g_free(w);
}
--
MST
- [Qemu-devel] [PULL 00/11] pci, pc fixes, features, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 01/11] hostmem: set MPOL_MF_MOVE, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 02/11] pci_bridge: manually destroy memory regions within PCIBridgeWindows,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 03/11] pcihp: fix possible array out of bounds, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 05/11] Add ACPI tables for TPM, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 04/11] pc: reserve more memory for ACPI for new machine types, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 07/11] pcie: Fix incorrect write to the ari capability next function field, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 06/11] ssdt-tpm: add generated hex file to git, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 08/11] pcie: Rename the pcie_cap_ari_* functions to pcie_cap_arifwd_*, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 09/11] ioh3420: Remove obsoleted, unused ioh3420_init function, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 10/11] ioh3420: Enable ARI forwarding, Michael S. Tsirkin, 2014/08/24
- [Qemu-devel] [PULL 11/11] pcie: fix trailing whitespace, Michael S. Tsirkin, 2014/08/24
- Re: [Qemu-devel] [PULL 00/11] pci, pc fixes, features, Peter Maydell, 2014/08/25