[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] device_tree.c: redirect load_device_tree err me
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] device_tree.c: redirect load_device_tree err message to stderr |
Date: |
Tue, 26 Aug 2014 13:44:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
"john.liuli" <address@hidden> writes:
> From: Li Liu <address@hidden>
>
> Signed-off-by: Li Liu <address@hidden>
> ---
> device_tree.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/device_tree.c b/device_tree.c
> index ca83504..ccdb039 100644
> --- a/device_tree.c
> +++ b/device_tree.c
> @@ -79,7 +79,7 @@ void *load_device_tree(const char *filename_path, int
> *sizep)
> *sizep = 0;
> dt_size = get_image_size(filename_path);
> if (dt_size < 0) {
> - printf("Unable to get size of device tree file '%s'\n",
> + fprintf(stderr, "Unable to get size of device tree file '%s'\n",
> filename_path);
> goto fail;
> }
> @@ -92,20 +92,20 @@ void *load_device_tree(const char *filename_path, int
> *sizep)
>
> dt_file_load_size = load_image(filename_path, fdt);
> if (dt_file_load_size < 0) {
> - printf("Unable to open device tree file '%s'\n",
> + fprintf(stderr, "Unable to open device tree file '%s'\n",
> filename_path);
> goto fail;
> }
>
> ret = fdt_open_into(fdt, fdt, dt_size);
> if (ret) {
> - printf("Unable to copy device tree in memory\n");
> + fprintf(stderr, "Unable to copy device tree in memory\n");
> goto fail;
> }
>
> /* Check sanity of device tree */
> if (fdt_check_header(fdt)) {
> - printf ("Device tree file loaded into memory is invalid: %s\n",
> + fprintf(stderr, "Device tree file loaded into memory is invalid:
> %s\n",
> filename_path);
> goto fail;
> }
A welcome improvement. Further improvement would be using
error_report().