[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for
|
From: |
Gonglei (Arei) |
|
Subject: |
Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function for 'qom-set' |
|
Date: |
Thu, 28 Aug 2014 14:12:24 +0000 |
> From: Eric Blake [mailto:address@hidden
> Subject: Re: [Qemu-devel] [PATCH] qmp: using genneric string paring function
> for 'qom-set'
>
> On 08/27/2014 11:19 PM, address@hidden wrote:
> > From: Gonglei <address@hidden>
> >
>
> In the subject: s/genneric/generic/, s/paring/parsing/
>
OK.
> > At present, 'qom-set' only can set string type property,
>
> qom-set is typed as taking arbitrary JSON 9one of the few commands with
> 'gen':'no', which means it is completely type-unsafe, and can therefore
> accept EVERY type, including JSON integers, not just strings).
>
Yep. Thanks, Eric. This is my fault.
> > which will restrict this qmp command's function.
> > Using genneric string paring function can handle different
>
> Same typos here as in subject.
>
Yep. Thanks for your review.
Best regards,
-Gonglei
> > types, such as int/bool/string etc.
> >
> > Signed-off-by: Gonglei <address@hidden>
> > ---
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org