[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-stable] [PATCH 06/25] pci: Use bus master address
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [Qemu-stable] [PATCH 06/25] pci: Use bus master address space for delivering MSI/MSI-X messages |
Date: |
Thu, 28 Aug 2014 09:39:30 -0500 |
User-agent: |
alot/0.3.4 |
Quoting Greg Kurz (2014-08-28 05:18:06)
> On Wed, 27 Aug 2014 12:36:03 -0500
> Michael Roth <address@hidden> wrote:
> > From: Jan Kiszka <address@hidden>
> >
> > The spec says (and real HW confirms this) that, if the bus master bit
> > is 0, the device will not generate any PCI accesses. MSI and MSI-X
> > messages fall among these, so we should use the corresponding address
> > space to deliver them. This will prevent delivery if bus master support
> > is disabled.
> >
> > Cc: address@hidden
> > Signed-off-by: Jan Kiszka <address@hidden>
> > Reviewed-by: Michael S. Tsirkin <address@hidden>
> > Signed-off-by: Michael S. Tsirkin <address@hidden>
> > (cherry picked from commit cc943c36faa192cd4b32af8fe5edb31894017d35)
> > Signed-off-by: Michael Roth <address@hidden>
> > ---
>
> Hi Michael,
>
> This commit breaks virtio for spapr. A fix is available in Alex's ppc-next:
>
> From: Greg Kurz <address@hidden>
> spapr_pci: map the MSI window in each PHB
>
> https://github.com/agraf/qemu/commit/7af2868fc76857e19c232bbe9e99a95d61138213
Thanks, I've gone ahead and applied it. Tested virtio + pseries before/after
and it seems to fix the issue.
>
> Cheers.
>
> --
> Greg
>
> > hw/pci/msi.c | 2 +-
> > hw/pci/msix.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/pci/msi.c b/hw/pci/msi.c
> > index a4a3040..52d2313 100644
> > --- a/hw/pci/msi.c
> > +++ b/hw/pci/msi.c
> > @@ -291,7 +291,7 @@ void msi_notify(PCIDevice *dev, unsigned int vector)
> > "notify vector 0x%x"
> > " address: 0x%"PRIx64" data: 0x%"PRIx32"\n",
> > vector, msg.address, msg.data);
> > - stl_le_phys(&address_space_memory, msg.address, msg.data);
> > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data);
> > }
> >
> > /* Normally called by pci_default_write_config(). */
> > diff --git a/hw/pci/msix.c b/hw/pci/msix.c
> > index 5c49bfc..20ae476 100644
> > --- a/hw/pci/msix.c
> > +++ b/hw/pci/msix.c
> > @@ -439,7 +439,7 @@ void msix_notify(PCIDevice *dev, unsigned vector)
> >
> > msg = msix_get_message(dev, vector);
> >
> > - stl_le_phys(&address_space_memory, msg.address, msg.data);
> > + stl_le_phys(&dev->bus_master_as, msg.address, msg.data);
> > }
> >
> > void msix_reset(PCIDevice *dev)
>
>
>
> --
> Gregory Kurz address@hidden
> address@hidden
> Software Engineer @ IBM/Meiosys http://www.ibm.com
> Tel +33 (0)562 165 496
>
> "Anarchy is about taking complete responsibility for yourself."
> Alan Moore.
- [Qemu-devel] [PATCH 03/25] vfio: Fix MSI-X vector expansion, (continued)
- [Qemu-devel] [PATCH 03/25] vfio: Fix MSI-X vector expansion, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 04/25] l2tpv3 (configure): it is linux-specific, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 07/25] hw:i386: typo fix: MEMORY_HOPTLUG_DEVICE -> MEMORY_HOTPLUG_DEVICE, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 02/25] qdev-monitor: include QOM properties in -device FOO, help output, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 05/25] ide: only constrain read/write requests to drive size, not other types, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 08/25] pc-dimm: validate node property, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 10/25] numa: show hex number in error message for consistency and prefix them with 0x, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 09/25] pc-dimm: fix up error message, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 06/25] pci: Use bus master address space for delivering MSI/MSI-X messages, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 12/25] virtio-blk: fix reference a pointer which might be freed, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 13/25] target-arm: Fix return address for A64 BRK instructions, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 11/25] acpi: align RSDP, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 16/25] block/iscsi: fix memory corruption on iscsi resize, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 15/25] arm/virt: Use PSCI v0.2 function IDs in the DT when KVM uses PSCI v0.2, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 18/25] qemu-iotests: add test case 101 for short file I/O, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 01/25] qmp: hide "hotplugged" device property from device-list-properties, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 20/25] vmxnet3: Pad short frames to minimum size (60 bytes), Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 17/25] raw-posix: fix O_DIRECT short reads, Michael Roth, 2014/08/27
- [Qemu-devel] [PATCH 21/25] hostmem: set MPOL_MF_MOVE, Michael Roth, 2014/08/27