[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] block: Loose dataplane dependency
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] block: Loose dataplane dependency |
Date: |
Fri, 29 Aug 2014 08:38:57 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 29/08/2014 03:25, Fam Zheng ha scritto:
> Before virtio-blk dataplane is switched to use block layer, it used to
> rely on the presence of linux-aio. Now the dependency is Linux, where
> the vring code has "#include <linux/virtio_ring.h>".
Can you instead move linux/virtio_ring.h to include/hw/virtio, with
__uNN types renamed to uNN_t?
Paolo
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> configure | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/configure b/configure
> index 2063cf6..a7d5a69fe 100755
> --- a/configure
> +++ b/configure
> @@ -2939,10 +2939,10 @@ fi
> # adjust virtio-blk-data-plane based on linux-aio
>
> if test "$virtio_blk_data_plane" = "yes" -a \
> - "$linux_aio" != "yes" ; then
> - error_exit "virtio-blk-data-plane requires Linux AIO, please try
> --enable-linux-aio"
> + "$linux" != "yes" ; then
> + error_exit "virtio-blk-data-plane requires Linux"
> elif test -z "$virtio_blk_data_plane" ; then
> - virtio_blk_data_plane=$linux_aio
> + virtio_blk_data_plane=$linux
> fi
>
> ##########################################
>