qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization


From: Marc Marí
Subject: Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization
Date: Fri, 29 Aug 2014 21:45:24 +0200

El Fri, 29 Aug 2014 17:59:37 +0200
Paolo Bonzini <address@hidden> escribió:
> Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto:
> > for (i = 0; i < 8; ++i) {
> >     quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i);
> > }
> > if (qtest_big_endian() != qtest_host_endian()) {
> >     quad.u64 = bswap64(quad.u64);
> > }
> > return quard.u64;
> 
> Why not keep the logic in Marc's patch, just replacing the union with
> OR and shift?
> 
> Paolo

With OR and shift is clearer than thinking about why the endianness
must be different (when looking at the code again), at least for me.

Thanks
Marc



reply via email to

[Prev in Thread] Current Thread [Next in Thread]