Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

[Stefan Hajnoczi]

On Fri, Aug 29, 2014 at 05:59:37PM +0200, Paolo Bonzini wrote:
> Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto:
> > for (i = 0; i < 8; ++i) {
> >     quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i);
> > }
> > if (qtest_big_endian() != qtest_host_endian()) {
> >     quad.u64 = bswap64(quad.u64);
> > }
> > return quard.u64;
> 
> Why not keep the logic in Marc's patch, just replacing the union with OR
> and shift?

That's fine too.

Stefan

pgpxlor1yOvGm.pgp
Description: PGP signature