[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 2/5] util/qemu-sockets.c: Support specifying IPv4
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH v2 2/5] util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram() |
Date: |
Tue, 2 Sep 2014 11:24:14 +0100 |
Currently you can specify whether you want a UDP chardev backend
to be IPv4 or IPv6 using the ipv4 or ipv6 options if you use the
QemuOpts parsing code in inet_dgram_opts(). However the QMP struct
parsing code in socket_dgram() doesn't provide this flexibility
(which in turn prevents us from converting the UDP backend handling
to the new style QAPI framework).
Use the existing inet_addr_to_opts() function to convert the
remote->inet address to option strings; this handles ipv4 and
ipv6 flags as well as host and port. (It will also convert any
'to' specification, which is harmless as it is ignored in this
context.)
Signed-off-by: Peter Maydell <address@hidden>
---
util/qemu-sockets.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/util/qemu-sockets.c b/util/qemu-sockets.c
index 5d38395..4a25585 100644
--- a/util/qemu-sockets.c
+++ b/util/qemu-sockets.c
@@ -966,8 +966,7 @@ int socket_dgram(SocketAddress *remote, SocketAddress
*local, Error **errp)
opts = qemu_opts_create(&socket_optslist, NULL, 0, &error_abort);
switch (remote->kind) {
case SOCKET_ADDRESS_KIND_INET:
- qemu_opt_set(opts, "host", remote->inet->host);
- qemu_opt_set(opts, "port", remote->inet->port);
+ inet_addr_to_opts(opts, remote->inet);
if (local) {
qemu_opt_set(opts, "localaddr", local->inet->host);
qemu_opt_set(opts, "localport", local->inet->port);
--
1.9.1
- [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI, Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 3/5] qemu-char: Convert udp backend to QAPI, Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 2/5] util/qemu-sockets.c: Support specifying IPv4 or IPv6 in socket_dgram(),
Peter Maydell <=
- [Qemu-devel] [PATCH v2 5/5] qemu-char: Rename register_char_driver_qapi() to register_char_driver(), Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 1/5] qemu-char: Convert socket backend to QAPI, Peter Maydell, 2014/09/02
- [Qemu-devel] [PATCH v2 4/5] qemu-char: Remove register_char_driver() machinery, Peter Maydell, 2014/09/02
- Re: [Qemu-devel] [PATCH v2 0/5] Convert remaining legacy chardevs to QAPI, Paolo Bonzini, 2014/09/09