Re: [Qemu-devel] [PATCH 2/2] vmdk: fix buf leak in vmdk_parse_extents()

[Fam Zheng]

On Thu, 09/04 21:04, Stefan Hajnoczi wrote:
> vmdk_open_sparse() does not take ownership of buf so the caller always
> needs to free it.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  block/vmdk.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/vmdk.c b/block/vmdk.c
> index 9bf28f3..a1cb911 100644
> --- a/block/vmdk.c
> +++ b/block/vmdk.c
> @@ -846,8 +846,8 @@ static int vmdk_parse_extents(const char *desc, 
> BlockDriverState *bs,
>              } else {
>                  ret = vmdk_open_sparse(bs, extent_file, bs->open_flags, buf, 
> errp);
>              }
> +            g_free(buf);
>              if (ret) {
> -                g_free(buf);
>                  bdrv_unref(extent_file);
>                  return ret;
>              }
> -- 
> 1.9.3
> 
Reviewed-by: Fam Zheng <address@hidden>