[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption opti
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: fix filter of encryption option |
Date: |
Mon, 8 Sep 2014 10:14:25 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, Sep 04, 2014 at 05:03:01PM +0800, Hu Tao wrote:
> On Fri, Aug 29, 2014 at 05:06:20PM +0100, Stefan Hajnoczi wrote:
> > On Thu, Aug 28, 2014 at 04:56:03PM +0800, Hu Tao wrote:
> > > We should filter out encryption=on, too.
> > >
> > > Signed-off-by: Hu Tao <address@hidden>
> > > ---
> > > tests/qemu-iotests/common.filter | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/tests/qemu-iotests/common.filter
> > > b/tests/qemu-iotests/common.filter
> > > index 51192c8..362394e 100644
> > > --- a/tests/qemu-iotests/common.filter
> > > +++ b/tests/qemu-iotests/common.filter
> > > @@ -176,7 +176,7 @@ _filter_img_create()
> > > sed -e "s#$IMGPROTO:$TEST_DIR#TEST_DIR#g" \
> > > -e "s#$TEST_DIR#TEST_DIR#g" \
> > > -e "s#$IMGFMT#IMGFMT#g" \
> > > - -e "s# encryption=off##g" \
> > > + -e "s# encryption=\\(on\\|off\\)##g" \
> >
> > Why?
>
> This is considered a bug of _filter_img_create(). It should have filtered out
> driver specific option 'encryption=on', too.
You have not posted justification for this patch series. As far as I
know, there is no reason to filter these options.
And your series breaks qemu-iotests because you didn't update the .out
files.
NACK
Stefan
pgpZI8Qq4GH2p.pgp
Description: PGP signature