[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v7 RESEND 5/8] hostmem-ram: don't exit qemu if size
From: |
Hu Tao |
Subject: |
[Qemu-devel] [PATCH v7 RESEND 5/8] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big |
Date: |
Tue, 9 Sep 2014 13:27:58 +0800 |
When using monitor command object_add to add a memory backend whose
size is way too big to allocate memory for it, qemu just exits. In
the case we'd better give an error message and keep guest running.
The problem can be reproduced as follows:
1. run qemu
2. (monitor)object_add memory-backend-ram,size=100000G,id=ram0
Reviewed-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Hu Tao <address@hidden>
---
backends/hostmem-ram.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/hostmem-ram.c b/backends/hostmem-ram.c
index e55d066..a67a134 100644
--- a/backends/hostmem-ram.c
+++ b/backends/hostmem-ram.c
@@ -27,7 +27,7 @@ ram_backend_memory_alloc(HostMemoryBackend *backend, Error
**errp)
path = object_get_canonical_path_component(OBJECT(backend));
memory_region_init_ram(&backend->mr, OBJECT(backend), path,
- backend->size, &error_abort);
+ backend->size, errp);
g_free(path);
}
--
1.9.3
- [Qemu-devel] [PATCH v7 RESEND 0/8] memory API improvements and bug fixes for memory backends, Hu Tao, 2014/09/09
- [Qemu-devel] [PATCH v7 RESEND 5/8] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big,
Hu Tao <=
- [Qemu-devel] [PATCH v7 RESEND 6/8] exec: file_ram_alloc: don't exit if failed to preallocate memory, Hu Tao, 2014/09/09
- [Qemu-devel] [PATCH v7 RESEND 7/8] exec: report error when memory < hpagesize, Hu Tao, 2014/09/09
- [Qemu-devel] [PATCH v7 RESEND 8/8] exec: add parameter errp to gethugepagesize, Hu Tao, 2014/09/09
- Re: [Qemu-devel] [PATCH v7 RESEND 0/8] memory API improvements and bug fixes for memory backends, Paolo Bonzini, 2014/09/09