[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 RESEND 6/8] exec: file_ram_alloc: don't exit
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v7 RESEND 6/8] exec: file_ram_alloc: don't exit if failed to preallocate memory |
Date: |
Tue, 09 Sep 2014 13:23:41 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 |
Il 09/09/2014 07:27, Hu Tao ha scritto:
> diff --git a/exec.c b/exec.c
> index 2b9c4c5..0362cd8 100644
> --- a/exec.c
> +++ b/exec.c
> @@ -1129,8 +1129,8 @@ static void *file_ram_alloc(RAMBlock *block,
> return area;
>
> error:
> - if (mem_prealloc) {
> - exit(1);
> + if (area && area != MAP_FAILED) {
> + munmap(area, memory);
> }
"area" is being used uninitialized here, and os_mem_prealloc can still
do exit(1). I'm not sure what this patch is doing...
Paolo
> return NULL;
- [Qemu-devel] [PATCH v7 RESEND 2/8] memory: add parameter errp to memory_region_init_ram, (continued)
- [Qemu-devel] [PATCH v7 RESEND 5/8] hostmem-ram: don't exit qemu if size of memory-backend-ram is way too big, Hu Tao, 2014/09/09
- [Qemu-devel] [PATCH v7 RESEND 6/8] exec: file_ram_alloc: don't exit if failed to preallocate memory, Hu Tao, 2014/09/09
- Re: [Qemu-devel] [PATCH v7 RESEND 6/8] exec: file_ram_alloc: don't exit if failed to preallocate memory,
Paolo Bonzini <=
- [Qemu-devel] [PATCH v7 RESEND 7/8] exec: report error when memory < hpagesize, Hu Tao, 2014/09/09
- [Qemu-devel] [PATCH v7 RESEND 8/8] exec: add parameter errp to gethugepagesize, Hu Tao, 2014/09/09
- Re: [Qemu-devel] [PATCH v7 RESEND 0/8] memory API improvements and bug fixes for memory backends, Paolo Bonzini, 2014/09/09