[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 08/23] block: Eliminate BlockDriverState member device_name[] |
|
Date: |
Thu, 11 Sep 2014 20:45:17 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 09/10/2014 02:13 AM, Markus Armbruster wrote:
>> device_name[] is can become non-empty only in bdrv_new_named() and
>
> s/is //
Fixing, thanks!
>> bdrv_move_feature_fields(). The latter is used only to undo damage
>> done by bdrv_swap(). The former is called only by blk_new_with_bs().
>> Therefore, when a BlockDriverState's device_name[] is non-empty, then
>> it's owned by a BlockBackend.
>>
>> The converse is also true, because blk_attach_bs() is called only by
>> blk_new_with_bs() so far.
>>
>> Furthermore, blk_new_with_bs() keeps the two names equal.
>>
>> Therefore, device_name[] is redundant. Eliminate it.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
- Re: [Qemu-devel] [PATCH 05/23] block: Make BlockBackend own its BlockDriverState, (continued)
[Qemu-devel] [PATCH 15/23] ide: Complete conversion from BlockDriverState to BlockBackend, Markus Armbruster, 2014/09/10
[Qemu-devel] [PATCH 19/23] blockdev: Drop DriveInfo member enable_auto_del, Markus Armbruster, 2014/09/10
[Qemu-devel] [PATCH 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf, Markus Armbruster, 2014/09/10
[Qemu-devel] [PATCH 20/23] block/qapi: Convert qmp_query_block() to BlockBackend, Markus Armbruster, 2014/09/10