[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union ty
From: |
Michael Roth |
Subject: |
[Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types |
Date: |
Thu, 11 Sep 2014 18:20:56 -0500 |
This series introduces visit_start_enum and visit_end_enum as a way
of allowing visitors to trigger generated code to bail out on visiting
union fields if the visitor implementation deems doing so to be unsafe.
See patch 1 for the circumstances that cause the segfault in the
dealloc visitor.
This is a spin-off of a patch submitted by Fam Zheng earlier. See the
thread for additional background on why we're taking this approach:
http://thread.gmane.org/gmane.comp.emulators.qemu/296090
Fam, if you'd like to break out your iotest into another patch I
can include it as part of this series, otherwise it can be sent as
a follow-up.
include/qapi/visitor-impl.h | 2 ++
include/qapi/visitor.h | 2 ++
qapi/qapi-dealloc-visitor.c | 6 ++++++
qapi/qapi-visit-core.c | 15 +++++++++++++++
scripts/qapi-visit.py | 6 ++++++
tests/qapi-schema/qapi-schema-test.json | 10 ++++++++++
tests/qapi-schema/qapi-schema-test.out | 3 +++
tests/test-qmp-input-strict.c | 17 +++++++++++++++++
8 files changed, 61 insertions(+)
- [Qemu-devel] [PATCH 0/3] qapi: fix crash in dealloc visitor for union types,
Michael Roth <=