[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] iotests: Send the correct fd in socket_scm_
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] iotests: Send the correct fd in socket_scm_helper |
Date: |
Fri, 12 Sep 2014 09:04:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Stratos Psomadakis <address@hidden> writes:
> Make sure to pass the correct fd via SCM_RIGHTS in socket_scm_helper.c
> (i.e. fd_to_send, not socket-fd).
>
> Signed-off-by: Stratos Psomadakis <address@hidden>
> Signed-off-by: Dimitris Aragiorgis <address@hidden>
> ---
> tests/qemu-iotests/socket_scm_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/socket_scm_helper.c
> b/tests/qemu-iotests/socket_scm_helper.c
> index 0e2b285..8195983 100644
> --- a/tests/qemu-iotests/socket_scm_helper.c
> +++ b/tests/qemu-iotests/socket_scm_helper.c
> @@ -52,7 +52,7 @@ static int send_fd(int fd, int fd_to_send)
> cmsg->cmsg_len = CMSG_LEN(sizeof(int));
> cmsg->cmsg_level = SOL_SOCKET;
> cmsg->cmsg_type = SCM_RIGHTS;
> - memcpy(CMSG_DATA(cmsg), &fd, sizeof(int));
> + memcpy(CMSG_DATA(cmsg), &fd_to_send, sizeof(int));
>
> do {
> ret = sendmsg(fd, &msg, 0);
Ouch. Do you have an idea what's broken without this fix?
- [Qemu-devel] [PATCH 0/2] Monitor-related fixes, Stratos Psomadakis, 2014/09/11
- [Qemu-devel] [PATCH 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Stratos Psomadakis, 2014/09/11
- Re: [Qemu-devel] [PATCH 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Markus Armbruster, 2014/09/12
- Re: [Qemu-devel] [synnefo-devel] Re: [PATCH 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Stratos Psomadakis, 2014/09/12
- [Qemu-devel] [PATCH resend 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Stratos Psomadakis, 2014/09/12
- Re: [Qemu-devel] [PATCH resend 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Luiz Capitulino, 2014/09/12
- Re: [Qemu-devel] [synnefo-devel] Re: [PATCH resend 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Stratos Psomadakis, 2014/09/12
- Re: [Qemu-devel] [synnefo-devel] Re: [PATCH resend 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Luiz Capitulino, 2014/09/12
- Re: [Qemu-devel] [synnefo-devel] Re: [PATCH resend 1/2] monitor: Reset HMP mon->rs on CHR_EVENT_CLOSED, Stratos Psomadakis, 2014/09/13