[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.tx
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt |
Date: |
Fri, 12 Sep 2014 13:08:03 +0200 |
Hi,
> > +++ b/docs/specs/virtio-gpu.txt
> > @@ -0,0 +1,165 @@
> > +virtio-gpu specification
>
> I know you are just following existing bad practice in this directory,
> but it would be nice to declare copyright and license on this file.
Added copyright for now.
Dunno about license, IIRC GPLv2 isn't good for text, suggestions?
> > + This creates a 2D resource on the host with the specified width,
> > + height and format. Only a small subset of formats are support. The
>
> s/support/supported/
> and can you delineate that subset?
enum virtgpu_formats (text updated).
> > + This sets the scanout parameters for a single scanout. The
> > + resource_id is the resource to be scanned out from, along with a
> > + rectangle specified by x, y, width and height.
>
> Is it worth a mention here or generically up front where 0,0 is in
> relation to the screen, and in which direction positive numbers move?
> I'm assuming 0,0 is top left, and larger x moves right, larger y moves down.
Correct. Text updated.
> Are there restrictions against rectangles that overlap beyond screen
> boundaries?
Backing resource must cover the scanout completely.
With multiple heads (and therefore multiple scanouts) it is legal for
the scanouts to overlap or even be identical (=> screen mirroring).
Text updated.
thanks,
Gerd
- Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, (continued)
Re: [Qemu-devel] [PATCH 1/2] virtio-gpu/2d: add hardware spec include file, Peter Maydell, 2014/09/11
[Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt, Gerd Hoffmann, 2014/09/11
Re: [Qemu-devel] [PATCH 2/2] virtio-gpu/2d: add docs/specs/virtio-gpu.txt, Michael S. Tsirkin, 2014/09/14
Re: [Qemu-devel] [virtio-dev] [PATCH 0/2] virtio-gpu: hardware specification, Dave Airlie, 2014/09/12