[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] block: Improve message for device name clas
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] block: Improve message for device name clashing with node name |
Date: |
Sat, 13 Sep 2014 20:52:50 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
The Friday 12 Sep 2014 à 21:26:24 (+0200), Markus Armbruster wrote :
> Suggested-by: Benoit Canet <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> block.c | 3 ++-
> tests/qemu-iotests/087.out | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/block.c b/block.c
> index 6faf36f..02ea90f 100644
> --- a/block.c
> +++ b/block.c
> @@ -347,7 +347,8 @@ BlockDriverState *bdrv_new(const char *device_name, Error
> **errp)
> return NULL;
> }
> if (bdrv_find_node(device_name)) {
> - error_setg(errp, "Device with node-name '%s' already exists",
> + error_setg(errp,
> + "Device name '%s' conflicts with an existing node name",
> device_name);
> return NULL;
> }
> diff --git a/tests/qemu-iotests/087.out b/tests/qemu-iotests/087.out
> index 7fbee3f..75a54e0 100644
> --- a/tests/qemu-iotests/087.out
> +++ b/tests/qemu-iotests/087.out
> @@ -20,7 +20,7 @@ QMP_VERSION
> {"return": {}}
> {"return": {}}
> {"error": {"class": "GenericError", "desc": "Device with id 'disk' already
> exists"}}
> -{"error": {"class": "GenericError", "desc": "Device with node-name
> 'test-node' already exists"}}
> +{"error": {"class": "GenericError", "desc": "Device name 'test-node'
> conflicts with an existing node name"}}
> main-loop: WARNING: I/O thread spun for 1000 iterations
> {"error": {"class": "GenericError", "desc": "could not open disk image
> disk2: node-name=disk is conflicting with a device id"}}
> {"error": {"class": "GenericError", "desc": "could not open disk image
> disk2: Duplicate node name"}}
> --
> 1.9.3
>
Reviewed-by: Benoît Canet <address@hidden>
- [Qemu-devel] [PATCH 0/4] Miscellaneous block fixes, Markus Armbruster, 2014/09/12
- [Qemu-devel] [PATCH 3/4] qemu-nbd: Destroy the BlockDriverState properly, Markus Armbruster, 2014/09/12
- [Qemu-devel] [PATCH 4/4] block: Improve message for device name clashing with node name, Markus Armbruster, 2014/09/12
- [Qemu-devel] [PATCH 1/4] blockdev: Disentangle BlockDriverState and DriveInfo creation, Markus Armbruster, 2014/09/12
- [Qemu-devel] [PATCH 2/4] block: Keep DriveInfo alive until BlockDriverState dies, Markus Armbruster, 2014/09/12
- Re: [Qemu-devel] [PATCH 0/4] Miscellaneous block fixes, Kevin Wolf, 2014/09/22