Re: [Qemu-devel] [PATCH v2 2/4] qapi: dealloc visitor, implement visit_start_union

[Eric Blake]

On 09/17/2014 03:32 PM, Michael Roth wrote:
> If the .data field of a QAPI Union is NULL, we don't need to free
> any of the union fields.
> 
> Make use of the new visit_start_union interface to access this
> information and instruct the generated code to not visit these
> fields when this occurs.
> 
> Cc: address@hidden
> Reported-by: Fam Zheng <address@hidden>
> Suggested-by: Paolo Bonzini <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
> ---
>  qapi/qapi-dealloc-visitor.c | 26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
> 

The comment helps.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature