[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on subpr
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PULL 03/12] test-qdev-global-props: Run tests on subprocess |
Date: |
Thu, 18 Sep 2014 20:38:27 +0300 |
On Thu, Sep 18, 2014 at 07:06:16PM +0200, Paolo Bonzini wrote:
> Il 18/09/2014 18:29, Michael Roth ha scritto:
> > <snip>
> >
> >> > int main(int argc, char **argv)
> >> > {
> >> > g_test_init(&argc, &argv, NULL);
> >> > @@ -174,9 +200,20 @@ int main(int argc, char **argv)
> >> > type_register_static(&static_prop_type);
> >> > type_register_static(&dynamic_prop_type);
> >> >
> >> > - g_test_add_func("/qdev/properties/static/default",
> >> > test_static_prop);
> >> > - g_test_add_func("/qdev/properties/static/global",
> >> > test_static_globalprop);
> >> > - g_test_add_func("/qdev/properties/dynamic/global",
> >> > test_dynamic_globalprop);
> >> > + g_test_add_func("/qdev/properties/static/default/subprocess",
> >> > + test_static_prop_subprocess);
> >> > + g_test_add_func("/qdev/properties/static/default",
> >> > + test_static_prop);
> > Since in the code above test_static_prop is actually the test that re-runs
> > /qdev/properties/static/default/subprocess under g_test_trap_subprocess,
> > aren't
> > the tests (or test function implementations) backwards?
> >
>
> No, it's correct. The parent test is the parent function, the child
> test is the subprocess function. The child test is automagically
> skipped by GTest, I don't know how that works.
>
> Paolo
Based on the "subprocess" string in the path.
[Qemu-devel] [PULL 04/12] test-qdev-global-props: Initialize not_used=true for all props, Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 05/12] test-qdev-global-props: Test handling of hotpluggable and non-device types, Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 06/12] qdev: Rename qdev_prop_check_global() to qdev_prop_check_globals(), Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 07/12] qdev: Move global validation to a single function, Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 08/12] Revert "rng-egd: remove redundant free", Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 09/12] virtio-net: drop assert on vm stop, Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 10/12] Revert "virtio: don't call device on !vm_running", Michael S. Tsirkin, 2014/09/14
[Qemu-devel] [PULL 11/12] virtio-pci: enable bus master for old guests, Michael S. Tsirkin, 2014/09/14