[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm |
Date: |
Mon, 22 Sep 2014 12:42:47 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Mon, Sep 22, 2014 at 02:36:55PM +0300, Michael S. Tsirkin wrote:
> On Sun, Sep 21, 2014 at 03:38:59PM +0100, Alex Bligh wrote:
> > Add a configure option --enable-pc-1-0-qemu-kvm and the
> > corresponding --disable-pc-1-0-qemu-kvm, defaulting
> > to disabled.
> >
> > Rename machine type pc-1.0 to pc-1.0-qemu-git.
> >
> > Make pc-1.0 machine type an alias of either pc-1.0-qemu-kvm
> > or pc-1.0-qemu-git depending on the value of the config
> > option.
> >
> > Signed-off-by: Alex Bligh <address@hidden>
>
> I have to say, this one bothers me.
> We end up not being able to predict what does pc-1.0
> reference.
Yeah, this is not good. Any single machine type name should have
fixed semantics - having two different semantics depending on build
options means mgmt apps can no longer simply compare the machine
type name to determine if it is a match with the same name on a
different host.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- [Qemu-devel] [PATCH v3 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm, Alex Bligh, 2014/09/21
- [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Alex Bligh, 2014/09/21
- Re: [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Michael S. Tsirkin, 2014/09/22
- Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Paolo Bonzini, 2014/09/22
- Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Alex Bligh, 2014/09/22
- Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Paolo Bonzini, 2014/09/22
- Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Alex Bligh, 2014/09/22
- Re: [Qemu-devel] [libvirt] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Serge Hallyn, 2014/09/22
- Re: [Qemu-devel] [PATCH v3 2/2] Add configure option --enable-pc-1-0-qemu-kvm, Alex Bligh, 2014/09/22