[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo() |
Date: |
Thu, 25 Sep 2014 15:06:44 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 16.09.2014 um 20:12 hat Markus Armbruster geschrieben:
> The patch is big, but all it really does is replacing
>
> dinfo->bdrv
>
> by
>
> blk_bs(blk_by_legacy_dinfo(dinfo))
>
> The replacement is repetitive, but the conversion of device models to
> BlockBackend is imminent, and will shorten it to just
> blk_legacy_dinfo(dinfo).
>
> Line wrapping muddies the waters a bit. I also omit tests whether
> dinfo->bdrv is null, because it never is.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- Re: [Qemu-devel] [PATCH v3 02/23] block: New BlockBackend, (continued)
- [Qemu-devel] [PATCH v3 07/23] block: Eliminate bdrv_iterate(), use bdrv_next(), Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 10/23] block: Eliminate DriveInfo member bdrv, use blk_by_legacy_dinfo(), Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 04/23] block: Connect BlockBackend and DriveInfo, Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 08/23] block: Eliminate BlockDriverState member device_name[], Markus Armbruster, 2014/09/16
- [Qemu-devel] [PATCH v3 13/23] virtio-blk: Rename VirtIOBlkConf variables to conf, Markus Armbruster, 2014/09/16