[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion function
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions |
Date: |
Fri, 26 Sep 2014 08:25:03 +0200 |
> > > @@ -1572,19 +1585,19 @@ static void vga_draw_graphic(VGACommonState *s,
> > > int full_update)
> > bits = 8;
> > break;
> > case 15:
> > - v = VGA_DRAW_LINE15;
> > - bits = 16;
> > + v = big_endian_fb ? VGA_DRAW_LINE15_BE : VGA_DRAW_LINE15_LE;
> > + bits = 15;
> > break;
> > case 16:
> > - v = VGA_DRAW_LINE16;
> > - bits = 16;
> > + v = big_endian_fb ? VGA_DRAW_LINE16_BE : VGA_DRAW_LINE16_LE;
> > + bits = 15;
>
> Is the change from bits=16 to bits=15 correct in this case?
No, it isn't. Thanks for catching this, I'll go fix it up.
cheers,
Gerd
- [Qemu-devel] [PATCH 4/8] vga: Remove rgb_to_pixel indirection, (continued)
- [Qemu-devel] [PATCH 4/8] vga: Remove rgb_to_pixel indirection, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 1/8] vga: Start cutting out non-32bpp conversion support, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 6/8] cirrus: Remove non-32bpp cursor drawing, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 7/8] vga: Remove some "should be done in BIOS" comments, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 3/8] vga: Separate LE and BE conversion functions, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 2/8] vga: Remove remainder of old conversion cruft, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 5/8] vga: Simplify vga_draw_blank() a bit, Gerd Hoffmann, 2014/09/22
- [Qemu-devel] [PATCH 8/8] vga: Rename vga_template.h to vga-helpers.h, Gerd Hoffmann, 2014/09/22