Re: [Qemu-devel] [PATCH v1 2/3] qom: export object_property_is_child()

[Andreas Färber]

Am 18.09.2014 um 09:53 schrieb Zhu Guihua:
> Export object_property_is_child() to let it be invoked in other places.
> 
> Signed-off-by: Zhu Guihua <address@hidden>
> ---
>  include/qom/object.h | 1 +
>  qom/object.c         | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 5d55889..8f27b7c 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -1302,4 +1302,5 @@ Object *container_get(Object *root, const char *path);
>  
>  void *object_property_get_opaque(ObjectProperty *prop, Error **errp);
>  
> +bool object_property_is_child(ObjectProperty *prop);

You already dropped one white line in the previous patch, now you're
leaving no spacing at all. Please always leave at least one before the
header guard.

Regards,
Andreas

>  #endif
> diff --git a/qom/object.c b/qom/object.c
> index 00a25e0..8de2599 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -351,7 +351,7 @@ void object_initialize(void *data, size_t size, const 
> char *typename)
>      object_initialize_with_type(data, size, type);
>  }
>  
> -static inline bool object_property_is_child(ObjectProperty *prop)
> +bool object_property_is_child(ObjectProperty *prop)
>  {
>      return strstart(prop->type, "child<", NULL);
>  }
> 


-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg