Re: [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API

[Cornelia Huck]

On Fri, 26 Sep 2014 09:28:05 +0000
Igor Mammedov <address@hidden> wrote:

> Changes since v1:
>   * added usb-uas test
>   * drop hotplug check in bus_add_child()
>   * make SCSI & USB bus as default HotplugHandler
>   * fixed dummy HBA hot(un)plug
>   * fixed hotunplug on s390x
>   * prevent hotplug of non hotpluggable devices
> --
> 
> Series unifies different hotplug mechanisms to a recent
> hotplug-handler API and does shallow conversion of
> devices that still use legacy qdev hotplug to it dropping
> not used after that legacy hotplug path [29/30].
> It also relaces SCSI's own way to do hotplug/unplug with
> hotplug-handler callbacks leaving it the only method
> perform hotplug tasks.
> And the last patch [30/30] allows to unplug of BUS-less
> devices using hotplug-handler API.
> 
> Converted devices are covered with new hotplug
> unit-tests, except of:
>  s390x-*: I have no idea how or means to test it, but code
>           is close to virtio, so it's converted using
>           virtio template
>  pvscsi: is broken, so no means to test it
> 
> Git tree for testing:
>   https://github.com/imammedo/qemu/commits/hp_ctrl_conversion_v2

I've played around with attaching/detaching virtio devices on the
s390-virtio and the s390-virtio-ccw machines. Everything seemed to work
as before.

I'll still take a look at the s390-related patches.