[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility |
Date: |
Fri, 26 Sep 2014 12:52:36 +0200 |
On Fri, 26 Sep 2014 09:28:28 +0000
Igor Mammedov <address@hidden> wrote:
> s390-sclp-event-facility creates s390-sclp-events-bus
> and immeadiatly sets its allow_hotplug field to 0,
> which is NOP since it's already 0 by default.
>
> Also since BUS is not hotpluggable, it's not possible
> to call SCLP_EVENT{ DeviceClass.unplug } callback
> from qdev_unplug() making this unreachable code,
> so drop it as well.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> Reviewed-by: Paolo Bonzini <address@hidden>
> ---
> hw/s390x/event-facility.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Cornelia Huck <address@hidden>
- [Qemu-devel] [PATCH v2 13/36] qdev: do not allow to instantiate non hotpluggable device with device_add, (continued)
- [Qemu-devel] [PATCH v2 13/36] qdev: do not allow to instantiate non hotpluggable device with device_add, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 14/36] qdev: HotplugHandler: rename unplug callback to unplug_request, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 15/36] qdev: HotplugHandler: provide unplug callback, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 16/36] qdev: add simple/generic unplug callback for HotplugHandler, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 18/36] qdev: drop hotplug check from bus_add_child(), Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 17/36] qdev: add wrapper to set BUS as HotplugHandler, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 20/36] virtio-pci: drop BusState.allow_hotplug, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 21/36] virtio-serial: convert to hotplug-handler API, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 22/36] virtio-mmio: drop useless bus->allow_hotplug = 0, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility, Igor Mammedov, 2014/09/26
- Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility,
Cornelia Huck <=
- [Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v3 24/36] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/26
- [Qemu-devel] [PATCH v4 24/36] s390x: convert s390-virtio to hotplug handler API, Igor Mammedov, 2014/09/26
[Qemu-devel] [PATCH v2 25/36] s390x: convert virtio-ccw to hotplug handler API, Igor Mammedov, 2014/09/26