Re: [Qemu-devel] [PATCH v2 05/12] virtio-serial: use aliases instead of duplicate qdev properties

[Cornelia Huck]

On Tue, 30 Sep 2014 14:10:31 +0800
<address@hidden> wrote:

> From: Gonglei <address@hidden>
> 
> virtio-serial-{pci, s390, ccw} all duplicate the
> qdev properties of their VirtIOSerial child.
> This approach does not work well with string or pointer
> properties since we must be careful about leaking or
> double-freeing them.
> 
> Use the QOM alias property to forward property accesses to the
> VirtIOSerial child.  This way no duplication is necessary.
> 
> Signed-off-by: Gonglei <address@hidden>
> ---
>  hw/s390x/s390-virtio-bus.c | 2 +-
>  hw/s390x/virtio-ccw.c      | 2 +-
>  hw/virtio/virtio-pci.c     | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Cornelia Huck <address@hidden>