[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 04/39] virtio-scsi: clean up virtio_scsi_parse_cdb
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PULL 04/39] virtio-scsi: clean up virtio_scsi_parse_cdb |
Date: |
Tue, 30 Sep 2014 14:24:44 +0200 |
The command direction according to the guest-passed buffers
is already stored in the VirtIOSCSIReq. We can use it instead
of computing it again from req->elem.
Cc: Laszlo Ersek <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
hw/scsi/virtio-scsi.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index f0d21a3..6953cbe 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -430,13 +430,7 @@ static int virtio_scsi_parse_cdb(SCSIDevice *dev,
SCSICommand *cmd,
* host device passthrough.
*/
cmd->xfer = req->qsgl.size;
- if (cmd->xfer == 0) {
- cmd->mode = SCSI_XFER_NONE;
- } else if (iov_size(req->elem.in_sg, req->elem.in_num) > req->resp_size) {
- cmd->mode = SCSI_XFER_FROM_DEV;
- } else {
- cmd->mode = SCSI_XFER_TO_DEV;
- }
+ cmd->mode = req->mode;
return 0;
}
--
1.8.3.1
- [Qemu-devel] [PULL 00/39] SCSI changes for 2014-09-23, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 03/39] vhost-scsi: use virtio_ldl_p, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 01/39] scsi: Optimize scsi_req_alloc, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 02/39] virtio-scsi: Optimize virtio_scsi_init_req, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 04/39] virtio-scsi: clean up virtio_scsi_parse_cdb,
Paolo Bonzini <=
- [Qemu-devel] [PULL 10/39] virtio-net: use aliases instead of duplicate qdev properties, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 06/39] virtio-scsi: Split virtio_scsi_handle_ctrl_req from virtio_scsi_handle_ctrl, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 05/39] virtio-scsi: Split virtio_scsi_handle_cmd_req from virtio_scsi_handle_cmd, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 11/39] virtio-net: fix virtio-net child refcount in transports, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 12/39] virtio/vhost-scsi: use aliases instead of duplicate qdev properties, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 13/39] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 08/39] virtio-scsi: Make virtio_scsi_free_req public, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 07/39] virtio-scsi: Make virtio_scsi_init_req public, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 09/39] virtio-scsi: Make virtio_scsi_push_event public, Paolo Bonzini, 2014/09/30
- [Qemu-devel] [PULL 14/39] virtio-serial: use aliases instead of duplicate qdev properties, Paolo Bonzini, 2014/09/30