[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() functi
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function |
|
Date: |
Mon, 6 Oct 2014 19:01:28 +0100 |
On 6 October 2014 18:57, Sergey Fedorov <address@hidden> wrote:
> On 06.10.2014 07:56, Peter Maydell wrote:
>> Can these functions live in internals.h rather than cpu.h?
>> (The difference is that internals.h is restricted to only
>> target-arm/ code whereas cpu.h is auto-included for a much
>> wider set of files.)
>
> Probably arm_is_secure() would be used by ARM GIC emulation until there
> is no better way to determine memory transaction NS tag.
We could have the GIC code temporarily include
internals.h, which would be a nice big red flag that
it was doing things the wrong way :-)
-- PMM