[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() functi
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v5 02/33] target-arm: add arm_is_secure() function |
|
Date: |
Mon, 6 Oct 2014 22:07:34 +0100 |
On 6 October 2014 21:47, Greg Bellows <address@hidden> wrote:
>
>
> On 6 October 2014 15:07, Peter Maydell <address@hidden> wrote:
>> You should use is_a64() rather than directly looking at
>> env->aarch64, incidentally.
>
>
> Since I am touching arm_current_el(), should I go ahead and fix it to use
> is_a64() as well?
Optional.
> I'll move in v6. Should I also go ahead and move arm_current_el() to
> internals.h as well since I am touching it?
No. Let's try to keep the scope of this patchset under control.
-- PMM