[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits |
Date: |
Mon, 13 Oct 2014 12:55:11 +0200 |
On Mon, 13 Oct 2014 16:23:58 +1030
Rusty Russell <address@hidden> wrote:
> Cornelia Huck <address@hidden> writes:
> > With virtio-1, we support more than 32 feature bits. Let's make
> > vdev->guest_features depend on the number of supported feature bits,
> > allowing us to grow the feature bits automatically.
>
> It's a judgement call, but I would say that simply using uint64_t
> will be sufficient for quite a while.
I prefer this as an array for two reasons:
- It matches what ccw does anyway (we read/write features in chunks of
32 bit), so this makes the backend handling for this transport very
straightforward.
- While I don't see us running out of 64 feature bits for a while, we'd
have to touch every device and transport again when we do. I'd prefer
to do this once, as we need to change code anyway.
- [Qemu-devel] [PATCH RFC 00/11] qemu: towards virtio-1 host support, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 09/11] s390x/virtio-ccw: add virtio set-revision call, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 03/11] virtio: support more feature bits, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 11/11] s390x/virtio-ccw: enable virtio 1.0, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 08/11] s390x/css: Add a callback for when subchannel gets disabled, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 02/11] virtio: cull virtio_bus_set_vdev_features, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 05/11] virtio: introduce legacy virtio devices, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 06/11] virtio: allow virtio-1 queue layout, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 10/11] s390x/virtio-ccw: support virtio-1 set_vq format, Cornelia Huck, 2014/10/07
- [Qemu-devel] [PATCH RFC 04/11] s390x/virtio-ccw: fix check for WRITE_FEAT, Cornelia Huck, 2014/10/07