[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] qdev: add qdev_build_hotpluggable_device
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] qdev: add qdev_build_hotpluggable_device_list helper |
Date: |
Thu, 16 Oct 2014 13:42:49 +0200 |
On Mon, 6 Oct 2014 19:38:43 +0800
Zhu Guihua <address@hidden> wrote:
> For peripheral device del completion, add a function to build a list
> for hotpluggable devices.
>
> Signed-off-by: Zhu Guihua <address@hidden>
> ---
> hw/core/qdev.c | 14 ++++++++++++++
> include/hw/qdev-core.h | 2 ++
> 2 files changed, 16 insertions(+)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index fcb1638..5f4b2b9 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -801,6 +801,20 @@ void qdev_alias_all_properties(DeviceState
> *target, Object *source) } while (class !=
> object_class_by_name(TYPE_DEVICE)); }
>
> +int qdev_build_hotpluggable_device_list(Object *obj, void *opaque)
> +{
> + GSList **list = opaque;
> + DeviceState *dev = DEVICE(obj);
> + DeviceClass *dc = DEVICE_GET_CLASS(dev);
> +
> + if (dev->realized && dc->hotpluggable) {
pls use object_property_get_bool() to get value of hotpluggable property
since it's might not be enough to have dc->hotpluggable set to true to
be hotpluggable.
> + *list = g_slist_append(*list, dev);
> + }
> +
> + object_child_foreach(obj, qdev_build_hotpluggable_device_list,
> opaque);
> + return 0;
> +}
> +
> static bool device_get_realized(Object *obj, Error **errp)
> {
> DeviceState *dev = DEVICE(obj);
> diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
> index 178fee2..aa76fdc 100644
> --- a/include/hw/qdev-core.h
> +++ b/include/hw/qdev-core.h
> @@ -361,6 +361,8 @@ extern int qdev_hotplug;
>
> char *qdev_get_dev_path(DeviceState *dev);
>
> +int qdev_build_hotpluggable_device_list(Object *obj, void *opaque);
> +
> static inline void qbus_set_hotplug_handler(BusState *bus,
> DeviceState *handler, Error **errp)
> {