[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/2] vl.c: reduce exit on error code duplicat
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 2/2] vl.c: reduce exit on error code duplication |
|
Date: |
Mon, 20 Oct 2014 10:48:45 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 |
On 10/20/2014 06:29 AM, Igor Mammedov wrote:
> use error_report_fatal() helper instead of a bunch of
> if (local_err) {
> error_report(foo);
> error_free(local_err);
> exit(1);
> }
> code blocks
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> * s/exit_if_error/error_report_fatal/
> * move error_report_fatal() into util/error.c
> ---
> include/qemu/error-report.h | 2 ++
> util/error.c | 24 ++++++++++++++++++++++++
> vl.c | 34 ++++++----------------------------
> 3 files changed, 32 insertions(+), 28 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature