Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback

[Michael S. Tsirkin]

On Tue, Oct 21, 2014 at 01:09:19PM +0200, Gerd Hoffmann wrote:
> On Mo, 2014-10-20 at 20:38 +0200, Paolo Bonzini wrote:
> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote:
> > > What do you want to happen in this case?
> > > Won't this cause even more patches to fall to the floor?
> > >
> > > The benefit seems marginal, the risk high.
> > 
> > I agree with Michael.
> > 
> > Can we detect if get_maintainer.pl is invoked as a cccmd, and in this 
> > case default to --no-git-fallback?  If it is invoked manually, I would 
> > like to show the committers (I will then cherry pick the right ones).
> 
> How about making "get_maintainer.pl --git-fallback" actually do what it
> says?  Right now git it *not* used as fallback, it goes to git log
> unconditionally, even if there are hits in MAINTAINERS ...

It does?

How do you reproduce this behaviour?

$ ./scripts/get_maintainer.pl -f vl.c
Anthony Liguori <address@hidden> (supporter:Main loop)

Seems to stop if it sees a maintainer.

> Different behavior depending on whenever stdout is a tty or not should
> be doable too.
> 
> cheers,
>   Gerd
> 
>