qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback


From: Kirill Batuzov
Subject: Re: [Qemu-devel] [PATCH] get_maintainer.pl: Default to --no-git-fallback
Date: Tue, 21 Oct 2014 17:46:59 +0400 (MSK)
User-agent: Alpine 2.02 (DEB 1266 2009-07-14)

On Tue, 21 Oct 2014, Markus Armbruster wrote:

> Paolo Bonzini <address@hidden> writes:
> 
> > On 10/20/2014 04:15 PM, Michael S. Tsirkin wrote:
> >> What do you want to happen in this case?
> >> Won't this cause even more patches to fall to the floor?
> >>
> >> The benefit seems marginal, the risk high.
> >
> > I agree with Michael.
> >
> > Can we detect if get_maintainer.pl is invoked as a cccmd, and in this
> > case default to --no-git-fallback?  If it is invoked manually, I would
> > like to show the committers (I will then cherry pick the right ones).
> 
> I don't like context-sensitive defaults.  Too much magic.
> 
> What about this: if get_maintainer.pl comes up empty, it points you to
> --git-fallback.
>

I am in favor of this. Empty output does not tell a new contributors what
to do next. So either this or document it on corresponding wiki page.

-- 
Kirill



reply via email to

[Prev in Thread] Current Thread [Next in Thread]